chore(storage): Instrument existing metadata ops with storage trace package#11107
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
the
api: storage
|
@BrennaEpp could you PTAL and help check the CLA, thanks! |
Co-authored-by: Brenna N Epp <brennae@google.com>
cojenco
force-pushed
the
trace-existing-metadata
branch
from
53726f1 to
f70a8e5
Compare
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
one minor nit, otherwise looks good to me at this point.
cojenco
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
| opts := []option.ClientOption{ | ||
| option.WithTelemetryDisabled(), | ||
| } | ||
| multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, bucket string, prefix string, client *Client) { |
There was a problem hiding this comment.
Should this be a transportClientTest instead?
There was a problem hiding this comment.
We'd want to use multiTransportTest here to test trace instrumentation on the transport-agnostic layer. Also, we need to configure NewGRPCClient and NewClient by passing in ClientOption, which cannot be done via transportClientTest. See previous discussion
There was a problem hiding this comment.
transportClientTest has a check to not run if the emulator env var is not set
google-cloud-go/storage/client_test.go
Line 2175 in 48022ac
We should modify transportClientTest to allow configuration of client opts similar to multiTransportTest. Or add a check to this test specifically so it only runs on the emulator
cojenco
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
4 participants
Update: supersedes #11051